solve Invalid Email Format in Text Field #245 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey can you please provide some screenshots? It would be very helpful when I review the PR |
|
hieuwu
reviewed
Oct 11, 2024
...rc/main/java/com/hieuwu/groceriesstore/presentation/authentication/signin/SignInViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/hieuwu/groceriesstore/presentation/authentication/signin/SignInScreen.kt
Outdated
Show resolved
Hide resolved
- Added a coroutine to display a snackbar when an invalid email address is entered. - Used `withContext(Dispatchers.Main)` to ensure the snackbar is displayed on the main thread. - Displayed "Invalid Email address!!" message in the snackbar.
bug/email_format
|
|
@hieuwu, could you please check PR and Marge? I appreciate and consider your comments as I start my career as an open-source contributor. Thanks. |
hieuwu
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve Bug Report: Accepting Invalid Email Format in Text Field #245