Skip to content

Conversation

@natanasow
Copy link
Member

Description

Create acceptance tests for the feature based on the Acceptance Criteria created when designing the feature.

Related issue(s)

Fixes #4396

Testing Guide

Changes from original design (optional)

N/A

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@natanasow natanasow self-assigned this Oct 2, 2025
@natanasow natanasow added the enhancement New feature or request label Oct 2, 2025
@natanasow natanasow added this to the 0.73.0 milestone Oct 2, 2025
@natanasow natanasow changed the base branch from main to feat/transaction-pool October 2, 2025 12:38
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Test Results

 20 files  ±0  263 suites   - 2   18m 30s ⏱️ - 32m 45s
760 tests  - 2  751 ✅  - 1  5 💤 ±0  4 ❌  - 1 
780 runs  +2  771 ✅ +3  5 💤 ±0  4 ❌  - 1 

For more details on these failures, see this check.

Results for commit 6cbc389. ± Comparison against base commit 57c9fa1.

♻️ This comment has been updated with latest results.

@natanasow natanasow changed the base branch from feat/transaction-pool to main October 7, 2025 06:24
@natanasow natanasow changed the base branch from main to feat/transaction-pool October 7, 2025 06:24
@natanasow natanasow changed the base branch from feat/transaction-pool to main October 7, 2025 06:56
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Copy link
Contributor

@konstantinabl konstantinabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments and questions

Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
@natanasow natanasow marked this pull request as ready for review October 8, 2025 12:27
@natanasow natanasow requested review from a team as code owners October 8, 2025 12:27
@natanasow natanasow requested a review from acuarica October 8, 2025 12:27
@natanasow natanasow changed the base branch from main to feat/transaction-pool October 8, 2025 12:28
@natanasow natanasow merged commit 83341e6 into feat/transaction-pool Oct 8, 2025
60 of 68 checks passed
@natanasow natanasow deleted the 4396-create-acceptance-tests-for-tx-pool-feature branch October 8, 2025 13:06
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                    Coverage Diff                    @@
##           feat/transaction-pool    #4443      +/-   ##
=========================================================
+ Coverage                  94.78%   95.87%   +1.09%     
=========================================================
  Files                        126      126              
  Lines                      20315    20311       -4     
  Branches                    1688     1762      +74     
=========================================================
+ Hits                       19255    19473     +218     
+ Misses                      1035      814     -221     
+ Partials                      25       24       -1     
Flag Coverage Δ
config-service 98.81% <ø> (ø)
relay 90.93% <92.85%> (-0.01%) ⬇️
server 88.82% <ø> (?)
ws-server 98.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/eth.ts 99.49% <100.00%> (+<0.01%) ⬆️
packages/relay/src/lib/precheck.ts 98.73% <100.00%> (ø)
...thService/transactionService/TransactionService.ts 97.47% <100.00%> (-0.30%) ⬇️
...s/transactionPoolService/transactionPoolService.ts 100.00% <ø> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create acceptance tests for the transaction pool feature

3 participants