-
Notifications
You must be signed in to change notification settings - Fork 88
feat: create acceptance tests for tx pool feature #4443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create acceptance tests for tx pool feature #4443
Conversation
…#4398) Signed-off-by: nikolay <[email protected]>
…olService` interface (#4405) Signed-off-by: nikolay <[email protected]>
…/transaction-pool
…/transaction-pool
Signed-off-by: nikolay <[email protected]>
Test Results 20 files ±0 263 suites - 2 18m 30s ⏱️ - 32m 45s For more details on these failures, see this check. Results for commit 6cbc389. ± Comparison against base commit 57c9fa1. ♻️ This comment has been updated with latest results. |
…s-for-tx-pool-feature
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments and questions
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feat/transaction-pool #4443 +/- ##
=========================================================
+ Coverage 94.78% 95.87% +1.09%
=========================================================
Files 126 126
Lines 20315 20311 -4
Branches 1688 1762 +74
=========================================================
+ Hits 19255 19473 +218
+ Misses 1035 814 -221
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
Create acceptance tests for the feature based on the Acceptance Criteria created when designing the feature.
Related issue(s)
Fixes #4396
Testing Guide
Changes from original design (optional)
N/A
Additional work needed (optional)
N/A
Checklist