Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt flutter_lints and use lowerCamelCase to Event enum. #263

Merged
merged 5 commits into from
May 13, 2023
Merged

Adapt flutter_lints and use lowerCamelCase to Event enum. #263

merged 5 commits into from
May 13, 2023

Conversation

ryojiro
Copy link
Contributor

@ryojiro ryojiro commented Apr 2, 2023 •
edited
Loading

This PR is after #262

I adapt flutter_lints to this project.

enum Event values are used SCREAMING_CAPS. However, it is not recommended in Dart.
See https://dart.dev/guides/language/effective-dart/style#prefer-using-lowercamelcase-for-constant-names

So This PR converts these Event values into lowerCamelCase.

Also,

@hiennguyen92 hiennguyen92 changed the base branch from master to dev May 13, 2023 07:45
@hiennguyen92 hiennguyen92 merged commit 36c4fc6 into hiennguyen92:dev May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryojiro @hiennguyen92