Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android notification channel name #177

Merged

Conversation

AAkira
Copy link
Contributor

@AAkira AAkira commented Sep 13, 2022

Currently, Android notification channel names are fixed.
It can now be passed as optional.

  • IncomingCallNotificationChannelName
  • MissedCallNotificationChannelName

@AAkira AAkira changed the title Add android notification channel Add android notification channel name Sep 13, 2022
@hiennguyen92
Copy link
Owner

please use name default in native code. to make sure it always works as before without it

@AAkira
Copy link
Contributor Author

AAkira commented Sep 14, 2022

Using name default is fine.
But the notification channel name cannot contain an empty string, so we need to check an empty string instead of a null check.
I think the null check is simple.

Which is better?

@hiennguyen92 hiennguyen92 merged commit 3ddc61d into hiennguyen92:master Sep 20, 2022
@AAkira AAkira deleted the add-android-notification-channel branch September 30, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants