Use arx::std namespace #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthijskooijman
force-pushed
the
use_arx_std_namespace
branch
2 times, most recently
from
6e1dbf9 to
1b2c8dc
Compare
hideakitai
reviewed
Sep 24, 2020
|
Can you add |
This fixes compatibility with libraries such as ArduinoSTL which make the standard header available on platforms that do not normally have it.
matthijskooijman
force-pushed
the
use_arx_std_namespace
branch
from
1b2c8dc to
98f00e3
Compare
|
w00ps, done :-) |
matthijskooijman
force-pushed
the
use_arx_std_namespace
branch
from
98f00e3 to
47b1eea
Compare
|
I think this PR is no longer relevant, all changes have been superseded by changes to ArxTypeTraits, so I'm closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a companion to hideakitai/ArxTypeTraits#2. It updates the embedded ArxTypeTraits to that version and renames all
std::references that are provided by ArxTypeTraits (everything except for the containers) toarx::std::.This also contains some related changes in ArxContainer that should be extracted eventually, but I just made them here for ease of review.