move std::move from C++11 to C++14 section #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C++14, std::move was changed to be constexpr. Since the version declared by ArxTypeTraits is (now) also constexpr, it should be declared in the C++14 section. This means if the standard library supports only C++11, the C++14 constexpr version is still available (must be referenced as arx::arx_std::move in this case, since we can't replace `std::move`). In practice, newer gcc versions actually expose the `constexpr` versions even when C++14 is not enabled, so it does not really matter there, but this could help in older versions that do not support C++14 at all yet.
Merged
hideakitai
added a commit
that referenced
this pull request
Sep 30, 2020
`move` must be declared before including `functional.h`. C++14 constexpr version should be inside of C++14, but moved before `functional.h`.
Owner
|
Oops, I missed compile error on tests/arduino_stl.ino... and fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++14, std::move was changed to be constexpr. Since the version
declared by ArxTypeTraits is (now) also constexpr, it should be declared
in the C++14 section. This means if the standard library supports only
C++11, the C++14 constexpr version is still available (must be
referenced as arx::arx_std::move in this case, since we can't replace
std::move).In practice, newer gcc versions actually expose the
constexprversionseven when C++14 is not enabled, so it does not really matter there, but
this could help in older versions that do not support C++14 at all yet.