Cbs/test pyoculus meson #444
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
- Coverage 92.52% 92.19% -0.34%
==========================================
Files 75 75
Lines 13830 13830
==========================================
- Hits 12796 12750 -46
- Misses 1034 1080 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
DO NOT MERGE THIS BRANCH, this is for discussion. @mbkumar @landreman This branch runs the tests with branches on VMEC2000 and pyoculus that have updated build systems. They all pass now, the failures are because of a coverage error. The containers are still installing pyoculus from pypi, thus getting errors. VMEC2000 fix: hiddenSymmetries/VMEC2000#17 pyoculus fix: zhisong/pyoculus#8 If we are happy with these fixes, merging them should make CI run again (except for the coverage issue). Are we happy with these fixes? |
fix setuptools version to lt.65 Confirmed to run past compilation stage in a branch that targets this change, see hiddenSymmetries/simsopt#444 and tests therein. (failing tests are due to coverage issues, before failure was vmec2000 installation step) merging to fix simsopt CI.
|
Closing as this test branche proved that fixing setuptools in pyoculus and vmec2000 solved the issue. These changes are now merged in their respective masters. |
DO NOT MERGE.
Triggering full gamut of tests on python version to test pyoculus meson install.
Will also need a pin on setuptools in VMEC2000 install to fully fix. see pypa/setuptools#3532.