[async-std-resolver] Re-export AsyncStdConnection(Provider)#1354
Merged
bluejekyll merged 1 commit intohickory-dns:mainfrom Jan 14, 2021
Merged
[async-std-resolver] Re-export AsyncStdConnection(Provider)#1354bluejekyll merged 1 commit intohickory-dns:mainfrom
bluejekyll merged 1 commit intohickory-dns:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 132 132
Lines 13775 13775
=======================================
Hits 11886 11886
Misses 1889 1889 |
Member
|
Thanks for the PR! |
|
@djc and @bluejekyll would it be possible to release a new version of |
Member
|
Yes, it's definitely possible. Let me see about a couple of PRs that might land soon before we do the next release. |
This was referenced Mar 16, 2021
|
Thanks @bluejekyll for the new release! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to the definition of
TokioAsyncResolverwith re-exportedTokioConnectionandTokioConnectionProvider, it would be useful to haveAsyncStdConnectionandAsyncStdConnectionProviderre-exported in the public API ofasync-std-resolver, so that types like thiscan be instantiated via