Skip to content

Commit

Permalink
HV-1731 Move back the sigtest testing into a profile
Browse files Browse the repository at this point in the history
It does not work with JDK 11+ as a deprecated annotation has been added
to Object#finalize().

It's built with a specific CI job.
  • Loading branch information
gsmet committed Aug 21, 2019
1 parent 156b7ef commit 8fc4263
Showing 1 changed file with 26 additions and 19 deletions.
45 changes: 26 additions & 19 deletions tck-runner/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -177,25 +177,6 @@
<outputName>test-report</outputName>
</configuration>
</plugin>
<plugin>
<groupId>org.netbeans.tools</groupId>
<artifactId>sigtest-maven-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<action>strictcheck</action>
<packages>javax.validation,javax.validation.bootstrap,javax.validation.constraints,
javax.validation.constraintvalidation,javax.validation.executable,javax.validation.groups,
javax.validation.metadata,javax.validation.spi,javax.validation.valueextraction
</packages>
<sigfile>${project.build.directory}/api-signature/validation-api-java8.sig</sigfile>
</configuration>
</plugin>
</plugins>
</build>

Expand Down Expand Up @@ -383,6 +364,32 @@
</plugins>
</build>
</profile>
<profile>
<id>sigtest</id>
<build>
<plugins>
<plugin>
<groupId>org.netbeans.tools</groupId>
<artifactId>sigtest-maven-plugin</artifactId>
<executions>
<execution>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<action>strictcheck</action>
<packages>javax.validation,javax.validation.bootstrap,javax.validation.constraints,
javax.validation.constraintvalidation,javax.validation.executable,javax.validation.groups,
javax.validation.metadata,javax.validation.spi,javax.validation.valueextraction
</packages>
<sigfile>${project.build.directory}/api-signature/validation-api-java8.sig</sigfile>
</configuration>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>jdk9+</id>
<activation>
Expand Down

0 comments on commit 8fc4263

Please sign in to comment.