HSEARCH-4112 Hibernate Search + Spring-JTA fails because of closed entity manager #2450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
force-pushed
the
HSEARCH-4112
branch
2 times, most recently
from
44ff60f to
e439c3a
Compare
yrodiere
force-pushed
the
HSEARCH-4112
branch
from
60f9151 to
62445b4
Compare
fax4ever
approved these changes
Nov 19, 2020
Contributor
fax4ever
left a comment
fax4ever
left a comment
There was a problem hiding this comment.
Really a nice job! +1 to merge it
Just very optional comments.
...rm/src/main/java/org/hibernate/search/mapper/orm/session/impl/HibernateOrmSearchSession.java
Outdated
Show resolved
Hide resolved
.../main/java/org/hibernate/search/mapper/orm/session/impl/HibernateOrmSearchSessionHolder.java
Show resolved
Hide resolved
Signed-off-by: Yoann Rodière <[email protected]>
…eOrmSearchSession We don't have anything to close anymore (we used to, a long time ago). Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
…the Search session or indexing plan As ludicrous as it may seem, JTA closes the session before the transaction is committed, so we need to be able to work on a closed session. Signed-off-by: Yoann Rodière <[email protected]>
…ntext when using JTA Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
So that we at least test lazy-loading Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
… to store the search session context Signed-off-by: Yoann Rodière <[email protected]>
Signed-off-by: Yoann Rodière <[email protected]>
yrodiere
force-pushed
the
HSEARCH-4112
branch
from
62445b4 to
2d81785
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HSEARCH-4112