HHH-19140 Reproducer test and issue fix #9758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladoKuruc
force-pushed
the
HHH-19140
branch
from
238d009 to
e601af7
Compare
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
VladoKuruc
force-pushed
the
HHH-19140
branch
from
d4be72f to
4d349e9
Compare
VladoKuruc
changed the title
mbellade
reviewed
Feb 24, 2025
hibernate-core/src/main/java/org/hibernate/property/access/internal/AccessStrategyHelper.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/property/access/internal/AccessStrategyHelper.java
Outdated
Show resolved
Hide resolved
VladoKuruc
force-pushed
the
HHH-19140
branch
from
4d349e9 to
9aed525
Compare
mbellade
reviewed
Feb 25, 2025
hibernate-core/src/main/java/org/hibernate/property/access/internal/AccessStrategyHelper.java
Outdated
Show resolved
Hide resolved
VladoKuruc
force-pushed
the
HHH-19140
branch
from
9aed525 to
5c6e865
Compare
mbellade
approved these changes
Feb 26, 2025
Member
mbellade
left a comment
mbellade
left a comment
There was a problem hiding this comment.
Thanks @VladoKuruc, I think having a unified implementation for finding the getter method is much better and will prevent similar problems in the future.
@sebersole wdyt about reading the @Access annotation's value instead of defaulting to FIELD or PROPERTY based on the annotation's placement?
beikov
reviewed
Mar 5, 2025
hibernate-core/src/main/java/org/hibernate/property/access/internal/AccessStrategyHelper.java
Outdated
Show resolved
Hide resolved
mbellade
approved these changes
Mar 10, 2025
Contributor
Author
|
Can you backport this to version 6.6 as well, please? |
VladoKuruc
added a commit
to VladoKuruc/hibernate-orm
that referenced
this pull request
Mar 14, 2025
* HHH-19140 Add test case * HHH-19140 Fix for issue
beikov
pushed a commit
that referenced
this pull request
Mar 14, 2025
* HHH-19140 Add test case * HHH-19140 Fix for issue
cigaly
pushed a commit
to cigaly/hibernate-orm
that referenced
this pull request
Mar 14, 2025
* HHH-19140 Add test case * HHH-19140 Fix for issue
yrodiere
pushed a commit
to yrodiere/hibernate-orm
that referenced
this pull request
Mar 18, 2025
* HHH-19140 Add test case * HHH-19140 Fix for issue
yrodiere
pushed a commit
to yrodiere/hibernate-orm
that referenced
this pull request
Mar 18, 2025
* HHH-19140 Add test case * HHH-19140 Fix for issue
Member
|
@VladoKuruc This So this test just isn't robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19140