HHH-19863 Calling EntityManager.lock() without an Active Transaction should throw jakarta.persistence.TransactionRequiredException #11371
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should throw jakarta.persistence.TransactionRequiredException Signed-off-by: Scott Marlow <[email protected]>
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
gavinking
requested changes
Dec 2, 2025
Member
gavinking
left a comment
gavinking
left a comment
There was a problem hiding this comment.
@scottmarlow As I mentioned on the issue persistence project, this should already have been taken care of by #11318.
Also: you're doing this to work around a bug in the platform TCK. You should fix the bug in the platform TCK instead.
So -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to check for active transaction before checking if the entity is managed.
Tracking issue is https://hibernate.atlassian.net/browse/HHH-19863
Zulip discussion is https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/em.23lock.20requirement.20to.20throw.20TransactionRequiredException/with/544678964 that talks about changing the order as this pull request does.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.