HHH-16383 - NaturalIdClass #11301
HHH-16383 - NaturalIdClass #11301
Conversation
|
Remaining work mostly comess down to implementing branch in See
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * Used in creating dynamic annotation instances (e.g. from XML) | ||
| */ | ||
| public NaturalIdClassAnnotation(ModelsContext modelContext) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| /** | ||
| * Used in creating annotation instances from JDK variant | ||
| */ | ||
| public NaturalIdClassAnnotation(NaturalIdClass annotation, ModelsContext modelContext) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
| /** | ||
| * Used in creating annotation instances from Jandex variant | ||
| */ | ||
| public NaturalIdClassAnnotation(Map<String, Object> attributeValues, ModelsContext modelContext) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
Show resolved
Hide resolved
sebersole
force-pushed
the
naturalidclass
branch
from
63883b8 to
159be18
Compare
|
A few things I still want to clean up (so please don't merge it), but this is mostly ready for review. |
| if ( factoryHint instanceof Integer number ) { | ||
| return Timeout.milliseconds( number ); | ||
| } | ||
| return Timeout.milliseconds( Integer.parseInt( factoryHint.toString() ) ); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| } | ||
| AccountId other = (AccountId) obj; | ||
| if (other != null && id != other.id) | ||
| if ( other != null && id != other.id ) { |
Check warning
Code scanning / CodeQL
Useless null check Warning test
# Conflicts: # hibernate-core/src/main/java/org/hibernate/metamodel/mapping/internal/CompoundNaturalIdMapping.java
sebersole
force-pushed
the
naturalidclass
branch
from
4d85ee1 to
19dbfd4
Compare
| var book = entityManager.find( Book.class, | ||
| "978-9730228236", | ||
| KeyType.NATURAL, | ||
| LockMode.PESSIMISTIC_WRITE, | ||
| Timeout.seconds( 1 ) ); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
| var books = entityManager.unwrap( Session.class ).findMultiple( Book.class, | ||
| List.of("978-9730228236"), | ||
| KeyType.NATURAL, | ||
| LockMode.PESSIMISTIC_WRITE, | ||
| Timeout.seconds( 1 ) ); |
Check notice
Code scanning / CodeQL
Unread local variable Note test
2 participants
HHH-16383 - NaturalIdClass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-16383