Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove next/*.js exports #647

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Sep 22, 2024

This one is added to help hi-ogawa/next-learn#1 (weird import by nextauth?) but it's fairly ugly (probably it confused IDE import completion too?) so let's forget about it and remove them.
Probably users can workaround it by doing alias manually.

I wonder what Next.js would end up eventually


Well, it looks like next-auth has fixed it already

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hi-ogawa and the rest of your teammates on Graphite Graphite

@hi-ogawa hi-ogawa changed the title refactor!: remove "next/*.js" exports refactor!: remove next/*.js exports Sep 22, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review September 22, 2024 07:42
hi-ogawa added a commit to hi-ogawa/next-learn that referenced this pull request Sep 22, 2024
@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Sep 22, 2024

Tested in hi-ogawa/next-learn#1 and it looks just fine with:

{
  resolve: {
    alias: {
      // workaround next-auth's unusual import until
      // https://github.com/nextauthjs/next-auth/pull/11551
      'next/server.js': 'next/server',
      'next/headers.js': 'next/headers',
      'next/navigation.js': 'next/navigation',
    }
  }
}

@hi-ogawa hi-ogawa merged commit ad02029 into main Sep 22, 2024
10 checks passed
@hi-ogawa hi-ogawa deleted the refactor-revert-js-exrpots branch September 22, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant