Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oracle规避对象名大小写敏感 #1438

Merged
merged 14 commits into from
Apr 26, 2022
Merged

oracle规避对象名大小写敏感 #1438

merged 14 commits into from
Apr 26, 2022

Conversation

peng19832
Copy link
Contributor

规避oracle对象名使用双引号

peng19832 and others added 10 commits November 4, 2021 09:40
规避oracle使用双引号引入的对象名大小写敏感问题
去除不需要的注释行
优化对象名使用双引号,导致的对象检查不存在问题
放开允许自动审核oracle的dml
规避双引号引起的对象名大小写,触发的对象检测问题
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1438 (6c80b08) into master (a952075) will decrease coverage by 0.21%.
The diff coverage is 22.50%.

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
- Coverage   75.43%   75.22%   -0.22%     
==========================================
  Files          91       91              
  Lines       14431    14477      +46     
==========================================
+ Hits        10886    10890       +4     
- Misses       3545     3587      +42     
Impacted Files Coverage Δ
sql/engines/oracle.py 45.02% <21.51%> (-2.95%) ⬇️
sql/utils/sql_utils.py 63.08% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a952075...6c80b08. Read the comment docs.

@peng19832
Copy link
Contributor Author

peng19832 commented Mar 31, 2022

我对写代码不是很在行。
这个逻辑,我在自己的环境是可以的。
请问下,我是需要对新增的每段代码,都写一个测试哇?

@LeoQuote
Copy link
Collaborator

LeoQuote commented Apr 1, 2022

还挺多改动的, 有空看看

sql/engines/oracle.py Show resolved Hide resolved
sql/engines/oracle.py Show resolved Hide resolved
sql/engines/oracle.py Show resolved Hide resolved
@peng19832
Copy link
Contributor Author

还挺多改动的, 有空看看

其实没改逻辑,只是字符串截取,想适配不同场景,大小写敏感的对象名的情况

sql/utils/sql_review.py Outdated Show resolved Hide resolved
@nick2wang
Copy link
Collaborator

没啥问题了

Copy link
Contributor Author

@peng19832 peng19832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finish

sql/engines/oracle.py Show resolved Hide resolved
@nick2wang nick2wang merged commit ca9bc3e into hhyo:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ bug ] Oracle工单,上线检测时,双引号引起的对象,检测错误
3 participants