Proposed Updates to section 3.2#6
Merged
hhhizzz merged 1 commit intohhhizzz:lm-pipeline-blogfrom Dec 7, 2025
Merged
Conversation
|
Preview URL: https://alamb.github.io/arrow-site If the preview URL doesn't work, you may forget to configure your fork repository for preview. |
alamb
commented
Dec 5, 2025
|
|
||
| [`RowSelection::scan_ranges`]: https://github.com/apache/arrow-rs/blob/ce4edd53203eb4bca96c10ebf3d2118299dad006/parquet/src/arrow/arrow_reader/selection.rs#L204 | ||
|
|
||
| Page skipping is illustrated in the following code example: |
Author
There was a problem hiding this comment.
i think it helps to add some explanation / context for the code and diagram
| assert_eq!(ranges.len(), 1); // Only request page1 | ||
| ``` | ||
|
|
||
| The following figure illustrates page skipping with RLE selections. The |
Author
There was a problem hiding this comment.
I think this is accurate after reading the diagram, though it would be good if @hhhizzz could double check me
Owner
There was a problem hiding this comment.
It's correct from my understanding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is some proposed "wordsmithing" changes for
I'll comment inline with the rationale