Split RowSelectionPolicy from RowSelectionStrategy #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/add_policy
branch
from
94d5737 to
631cb17
Compare
alamb
commented
Nov 10, 2025
| } | ||
| } | ||
|
|
||
| /// Fully resolved strategy for materializing [`RowSelection`] during execution. |
Author
There was a problem hiding this comment.
I eventually concluded that using a separate enum for the actual strategy to use was the clearest -- that way the type system encodes when Auto must have been resolved
| } | ||
| plan_builder = plan_builder.with_row_selection_policy(self.row_selection_policy); | ||
|
|
||
| plan_builder = overide_selector_strategy_if_needed( |
Author
There was a problem hiding this comment.
I also extracted this logic out into its own function, mostly so I could add the comments from apache#8733 (comment)
|
|
||
| /// Overrider the selection strategy if needed. | ||
| /// | ||
| /// Some pages can be skipped during row-group construction of they are not read |
| Auto { | ||
| /// Average selector length below which masks are preferred | ||
| threshold: usize, | ||
| /// Fallback to selectors when mask would be unsafe (e.g. page skipping) |
Author
There was a problem hiding this comment.
safe was always set to true, so I removed it as I believe it is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another PR that targets
There were several places in the code that assumed RowSelectionStrategy couldn't be
Auto-- I wanted to see if I could encode this into the type system so it was less potentially problematicI also think the context from @hhhizzz on apache#8733 (comment) was very important context so I adapted it as comments