Support additional parameters for infinityModel() #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: submitted this a bit prematurely; still adding support for |
bruce
changed the title
|
This is now ready for review. |
bruce
changed the title
|
|
||
| actions: { | ||
| infinityLoad: function() { | ||
| this._infinityLoad(); |
|
Really really nice! thankyou @bruce ! If you can squash this into a single commit - and add something to README to reflect this change, I'll merge and release asap |
|
Thanks! I'll get that in tonight/tomorrow morning. |
Additional options can be provided in the object passed to InfinityRoute's infinityModel() for use by DS.Store.find(). The perPage and startingPage properties will still be passed as per_page and page params, respectively. Tests are provided using a new /category/:category route in the dummy application.
|
@hhff Squashed and README content added. Thanks! |
hhff
added a commit
that referenced
this pull request
Apr 8, 2015
Support additional parameters for infinityModel() closes #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional options can be provided in the object passed to
InfinityRoute'sinfinityModel()for use byDS.Store.find().The
perPageandstartingPageproperties will still be passed asper_pageandpageparams, respectively.Acceptance tests use a new
/category/:categoryroute in thedummy application.
For #6.