-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support additional parameters for infinityModel() #9
Conversation
Note: submitted this a bit prematurely; still adding support for |
This is now ready for review. |
|
||
actions: { | ||
infinityLoad: function() { | ||
this._infinityLoad(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Really really nice! thankyou @bruce ! If you can squash this into a single commit - and add something to README to reflect this change, I'll merge and release asap |
Thanks! I'll get that in tonight/tomorrow morning. |
Additional options can be provided in the object passed to InfinityRoute's infinityModel() for use by DS.Store.find(). The perPage and startingPage properties will still be passed as per_page and page params, respectively. Tests are provided using a new /category/:category route in the dummy application.
@hhff Squashed and README content added. Thanks! |
Support additional parameters for infinityModel() closes #11
Additional options can be provided in the object passed to
InfinityRoute
'sinfinityModel()
for use byDS.Store.find()
.The
perPage
andstartingPage
properties will still be passed asper_page
andpage
params, respectively.Acceptance tests use a new
/category/:category
route in thedummy application.
For #6.