Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember cli 0.2.5 #20

Merged
merged 1 commit into from
May 21, 2015
Merged

Conversation

mike-north
Copy link
Collaborator

No description provided.

@@ -0,0 +1,3 @@
ul li {
height: 500px;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style was necessary in order to prevent multiple "pages" from loading in acceptance tests, before the first andThen callback was called

@mike-north
Copy link
Collaborator Author

Tests are now passing against

  • Ember 1.10
  • Ember 1.11.3
  • Ember 1.12 (release)
  • Ember 1.13-beta.1 (beta)
  • Embe 2.0 (canary)

It looks like some default "store" object was added to routes sometime during the 1.11 release cycle. I have modified your "is the store present" check on the route mixin to acommodate

This was referenced May 20, 2015
@hhff
Copy link
Collaborator

hhff commented May 21, 2015

This is awesome @truenorth - you're the man. Can you please squash the commits?

@mike-north
Copy link
Collaborator Author

@hhff Squashed

hhff added a commit that referenced this pull request May 21, 2015
@hhff hhff merged commit f1af7f2 into adopted-ember-addons:master May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants