Skip to content

Commit

Permalink
Tests passing against all framework channels
Browse files Browse the repository at this point in the history
  • Loading branch information
Mike North committed May 20, 2015
1 parent 91e73f7 commit d707623
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 7 deletions.
6 changes: 2 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,14 @@ cache:

env:
- EMBER_TRY_SCENARIO=default
- EMBER_TRY_SCENARIO=ember-1.10
- EMBER_TRY_SCENARIO=ember-1.11
- EMBER_TRY_SCENARIO=ember-release
- EMBER_TRY_SCENARIO=ember-beta
- EMBER_TRY_SCENARIO=ember-canary

matrix:
fast_finish: true
allow_failures:
- env: EMBER_TRY_SCENARIO=ember-release
- env: EMBER_TRY_SCENARIO=ember-beta
- env: EMBER_TRY_SCENARIO=ember-canary

before_install:
- export PATH=/usr/local/phantomjs-2.0.0/bin:$PATH
Expand Down
2 changes: 1 addition & 1 deletion addon/mixins/route.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export default Ember.Mixin.create({
infinityModel: function(modelName, options) {
var _this = this;

if (this.store === undefined){
if (Ember.isEmpty(this.store) || Ember.isEmpty(this.store.find)){
throw new Ember.Error("Ember Data store is not available to infinityModel");
} else if (modelName === undefined) {
throw new Ember.Error("You must pass a Model Name to infinityModel");
Expand Down
14 changes: 13 additions & 1 deletion config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,19 @@ module.exports = {
scenarios: [
{
name: 'default',
dependencies: { }
dependencies: {}
},
{
name: 'ember-1.10',
dependencies: {
'ember': '~1.10.0'
}
},
{
name: 'ember-1.11',
dependencies: {
'ember': '~1.11.3'
}
},
{
name: 'ember-release',
Expand Down
4 changes: 3 additions & 1 deletion tests/unit/mixins/route-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ test('it can not use infinityModel without a Model Name', function(assert) {
}
});
var route = RouteObject.create();
route.store = {};
route.store = {
find() {}
};

var infinityError;
try {
Expand Down

0 comments on commit d707623

Please sign in to comment.