Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E301 has been further split into E305, E306 #287

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

spaceone
Copy link
Contributor

@myint
Continuing #283

Copy link
Collaborator

@myint myint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like test_e12_reindent() needs to be fixed.

@@ -196,6 +196,8 @@ def qualify_by_address(
params_to_check=frozenset(QUALIF_BY_ADDRESS_PARAM)):
""" This gets called by the web server """
#: E129

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two empty lines should go before the comment.

@khairihafsham
Copy link
Contributor

Hi,

It seems this issue has been dormant for over 2 months now. Is there anything I could help to move things forward?

One thing I've noticed is that, if we split the issues (E306, E305) into separate task, it may help out things a bit, because E306 is more straight forward and does not introduce any breaking changes (I've tested with Python 2.7.10 and 3.5.1)

@khairihafsham khairihafsham mentioned this pull request Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants