Skip to content

Comments

Fix 2146: use BFS algorithm for shortest path#2147

Merged
hgrecco merged 4 commits intohgrecco:masterfrom
deanmalmgren:fix-2146-shortest-path
Mar 17, 2025
Merged

Fix 2146: use BFS algorithm for shortest path#2147
hgrecco merged 4 commits intohgrecco:masterfrom
deanmalmgren:fix-2146-shortest-path

Conversation

@deanmalmgren
Copy link
Contributor

@deanmalmgren deanmalmgren commented Feb 26, 2025

I've tried to use the pre-commit hooks, but it was complaining about code that was not in my changeset. It seems like some issues leaked into the master branch.

@deanmalmgren
Copy link
Contributor Author

@hgrecco is there anything else you need me to take care of as a part of this PR?

@hgrecco
Copy link
Owner

hgrecco commented Mar 5, 2025

It looks good to me. I will merge it in this upcoming days if there are no showstopeers! Thanks.

@deanmalmgren
Copy link
Contributor Author

@hgrecco not sure why the codspeed-benchmarks couldn't find pytest in the environment. Is there another patch PR that I can merge in that fixes this as I'm sure it'll be affecting other things. I'm wondering what else I can do to get this over the line...

@hgrecco hgrecco merged commit dc94eab into hgrecco:master Mar 17, 2025
3 of 4 checks passed
@hgrecco
Copy link
Owner

hgrecco commented Mar 17, 2025

@deanmalmgren Sorry for the long delay. Thanks a lot for the PR, it will be included in next pint version (scheduled for mid april)

@deanmalmgren
Copy link
Contributor Author

No apologies necessary. I know how challenging it can be to manage an open source project on top of everything else. Appreciate you. If there's anything else I can do, let me know.

@hgrecco
Copy link
Owner

hgrecco commented Mar 17, 2025

Just keep the great ideas and PR coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic contexts, currency conversion, and failing to find the shortest path

2 participants