Skip to content

Avoid looping on large numpy arrays #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewgsavage merged 2 commits into from
May 12, 2024
Merged

Avoid looping on large numpy arrays #1987

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55d86cf
Avoid looping on large numpy arrays
andrewgsavage May 12, 2024
d6a7697
Avoid looping on large numpy arrays
andrewgsavage May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pint/facets/numpy/numpy_func.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ def _is_sequence_with_quantity_elements(obj):
-------
True if obj is a sequence and at least one element is a Quantity; False otherwise
"""
if np is not None and isinstance(obj, np.ndarray) and not obj.dtype.hasobject:
# If obj is a numpy array, avoid looping on all elements
# if dtype does not have objects
return False
return (
iterable(obj)
and sized(obj)
Expand Down