Skip to content

to_compact: support uncertainties' Magnitudes #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
doronbehar wants to merge 1 commit into from
Closed

to_compact: support uncertainties' Magnitudes #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions pint/facets/plain/qto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

import bisect
import math
import numbers
import warnings

from ...util import infer_base_unit
from ...compat import (
Expand Down Expand Up @@ -100,18 +98,8 @@ def to_compact(
<Quantity(10.0, 'millinewton')>
"""

if not isinstance(quantity.magnitude, numbers.Number):
msg = "to_compact applied to non numerical types " "has an undefined behavior."
w = RuntimeWarning(msg)
warnings.warn(w, stacklevel=2)
return quantity

if (
quantity.unitless
or quantity.magnitude == 0
or math.isnan(quantity.magnitude)
or math.isinf(quantity.magnitude)
):
if quantity.unitless:
return quantity

SI_prefixes: dict[int, str] = {}
Expand All @@ -137,6 +125,11 @@ def to_compact(
q_base = quantity.to(unit)

magnitude = q_base.magnitude
# Support uncertainties
if hasattr(magnitude, 'nominal_value'):
magnitude = magnitude.nominal_value
if magnitude == 0 or math.isnan(magnitude) or math.isinf(magnitude):
return quantity

units = list(q_base._units.items())
units_numerator = [a for a in units if a[1] > 0]
Expand Down
2 changes: 1 addition & 1 deletion pint/testsuite/test_quantity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,7 @@ def test_limits_magnitudes(self):
def test_nonnumeric_magnitudes(self):
ureg = self.ureg
x = "some string" * ureg.m
with pytest.warns(RuntimeWarning):
with pytest.raises(TypeError):
self.compare_quantity_compact(x, x)

def test_very_large_to_compact(self):
Expand Down