fix(engine): detect onUpdate callbacks and enable verification events - #3794
Merged
Conversation
The static-frame dedup predictor walked tween intervals from window.__timelines but was blind to onUpdate callbacks — motion driven from a timeline's onUpdate in a tween-free window was predicted static. The verifier compounded the gap by seeking with suppressEvents: true, so the onUpdate never fired and the frozen frame passed verification. Two changes: 1. Predictor: when a timeline carries vars.onUpdate, mark its full span as animated so those frames are never predicted static. 2. Verifier: seek with suppressEvents: false so the verification page behaves identically to the capture page. The verification page is already isolated (separate Page instance), so out-of-order event side effects cannot corrupt sequential capture. Fixes #3793
miguel-heygen
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3793 — static-frame dedup:
onUpdate-driven motion in tween-free windows is predicted static and passes verification.Root cause: Two blind spots working together:
window.__timelinesbut ignoredonUpdatecallbacks — motion driven from a timeline'sonUpdatein a tween-free window was predicted static.suppressEvents: true, soonUpdatenever fired and the frozen frame passed verification.Fix (two changes):
vars.onUpdate, mark its full span as animated so those frames are never predicted static.suppressEvents: falseso the verification page behaves identically to the capture page. The verification page is already isolated (separatePageinstance created bycreateStaticVerificationPage), so out-of-order event side effects cannot corrupt sequential capture.Test plan
hw-*blocks with onUpdate-driven boil render correctly with default dedup— Miga