fix(skills): forward Kokoro TTS speed - #3665
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
miga-heygen
requested changes
Sep 4, 2026
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
The fix itself is correct: buildKokoroTtsArgs now always emits --speed, and synthesizeOne forwards its already-resolved speed into it. Tests cover both the non-default (1.16) and explicit-default (1) cases correctly.
However, CI is red: Skills: manifest in sync fails because skills-manifest.json wasn't regenerated after editing skills/media-use/audio/scripts/lib/tts.mjs (hash mismatch for the media-use skill: 00a2d26e22fc1ab1 -> ae2be19b68fe6e84). Please run bun run --cwd packages/cli gen:skills-manifest and commit the updated skills-manifest.json, then this is good to merge.
— Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Kokoro synthesis now receives the resolved TTS speed at the final subprocess boundary. A requested
--speed 1.16reachesnpx hyperframes ttsas--speed 1.16instead of silently using Kokoro’s 1.0 default.Why
The faceless adapter and shared audio request preserved speed correctly, but Kokoro argv construction dropped it. Synthesis still exited successfully, leaving narration audio and word timing at the wrong pace.
Related: #2335
Related: #2407
How
One Kokoro argument builder owns voice, output, speed, and optional language ordering.
synthesizeOnepasses its already-resolved speed into that builder, and the default 1.0 value is emitted explicitly under a tested contract.Test plan
--speed 1.16.--speed 1.