test(engine): give the real-ffmpeg group mix suite a 60s timeout - #3397
Closed
vanceingalls wants to merge 1 commit into
Closed
test(engine): give the real-ffmpeg group mix suite a 60s timeout#3397vanceingalls wants to merge 1 commit into
vanceingalls wants to merge 1 commit into
Conversation
`routing isolation` timed out at 30,000ms on the Windows runner again (#3401). It is not a hang and not that PR's doing — that diff touches no engine code, and on main's last passing Windows run the same test measured 10,050ms with the file at 19,446ms. A ~10s test under a 30s cap on a runner with this much variance fails on any bad host; 120s is ~12x the healthy time, so a timeout should mean a real stall again. Written as per-test arguments, replacing #3398's 30s ones. My earlier attempt at this (#3397) added `vi.setConfig({ testTimeout: 60_000 })` instead, which would have merged and changed nothing: an explicit per-test argument overrides the file-level config. Verified directly — a 50ms argument beats a 60s setConfig.
vanceingalls
force-pushed
the
fix/audio-mixer-windows-timeout
branch
from
August 21, 2026 22:48
5b44a86 to
16a9c29
Compare
miga-heygen
approved these changes
Aug 21, 2026
miga-heygen
left a comment
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Approve. Per-test timeout bump from 30s to 120s on the real-ffmpeg group mix suite — ~12x the healthy Linux time, generous enough to absorb Windows runner variance without masking a genuine stall. Comment explains the rationale clearly. Using per-test arguments rather than vi.setConfig is correct since the per-test arg overrides the file-level config. No issues.
— Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests on windows-latestfailed on #3290 withTest timed out in 5000msatmix level arithmetic > a group FX chain fully cutting its members leaves an ungrouped track untouched (routing isolation). #3290 merged before this fix landed on its branch, so it comes as its own PR.Every case in that suite shells out to real ffmpeg at least twice — the mix under test plus a reference mix to compare it against. 5s is enough on Linux and not on the Windows runner: a slow host, not a hung mix.
vi.setConfig({ testTimeout: 60_000 })rather than adescribe(..., 60_000)argument — the latter makes the callback a second parameter, and oxfmt then reindents all 170 lines of the suite for one number (354-line diff vs 8).🤖 Generated with Claude Code