Skip to content

fix(registry): clear flowchart selection after click-away #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AksharP5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(registry): clear flowchart selection after click-away #3262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions docs/catalog/blocks/flowchart-vertical.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ That writes one file: `compositions/flowchart-vertical.html`.
/>
</svg>
</div>
<div class="selection-border"></div>
</div>
<div id="node-nocode" class="node blue" style="left: 600px; top: 960px">
Try no-code first
Expand Down Expand Up @@ -335,7 +336,6 @@ That writes one file: `compositions/flowchart-vertical.html`.
(function () {
const tl = gsap.timeline({ paused: true });
const S = "#flowchart-vertical";
const nodePython = document.querySelector(S + " #node-python");
const pythonText = document.querySelector(S + " #python-text");

// 1. Root node scales in
Expand Down Expand Up @@ -406,15 +406,7 @@ That writes one file: `compositions/flowchart-vertical.html`.
tl.to(S + " #cursor", { x: -1110, y: -1560, duration: 1, ease: "power1.inOut" }, "hold3");

// 10. Cursor clicks — selection border
tl.add(() => {
if (!nodePython) return;
if (!nodePython.querySelector(".selection-border")) {
const border = document.createElement("div");
border.className = "selection-border";
nodePython.appendChild(border);
}
gsap.set(S + " .selection-border", { opacity: 1 });
}, "hold3+=1");
tl.set(S + " .selection-border", { opacity: 1 }, "hold3+=1");

tl.to(
S + " #cursor",
Expand Down
12 changes: 2 additions & 10 deletions docs/catalog/blocks/flowchart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ That writes one file: `compositions/flowchart.html`.
/>
</svg>
</div>
<div class="selection-border"></div>
</div>
<div id="node-nocode" class="node blue" style="left: 800px; top: 500px">
Try no-code first
Expand Down Expand Up @@ -335,7 +336,6 @@ That writes one file: `compositions/flowchart.html`.
(function () {
const tl = gsap.timeline({ paused: true });
const S = '[data-composition-id="flowchart"]';
const nodePython = document.querySelector(S + " #node-python");
const pythonText = document.querySelector(S + " #python-text");

// 1. Root node scales in
Expand Down Expand Up @@ -406,15 +406,7 @@ That writes one file: `compositions/flowchart.html`.
tl.to(S + " #cursor", { x: -1470, y: -540, duration: 1, ease: "power1.inOut" }, "hold3");

// 10. Cursor clicks — selection border
tl.add(() => {
if (!nodePython) return;
if (!nodePython.querySelector(".selection-border")) {
const border = document.createElement("div");
border.className = "selection-border";
nodePython.appendChild(border);
}
gsap.set(S + " .selection-border", { opacity: 1 });
}, "hold3+=1");
tl.set(S + " .selection-border", { opacity: 1 }, "hold3+=1");

tl.to(
S + " #cursor",
Expand Down
2 changes: 1 addition & 1 deletion docs/public/catalog/blocks/flowchart-vertical.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/public/catalog/blocks/flowchart.json
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 2 additions & 10 deletions registry/blocks/flowchart-vertical/flowchart-vertical.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
/>
</svg>
</div>
<div class="selection-border"></div>
</div>
<div id="node-nocode" class="node blue" style="left: 600px; top: 960px">
Try no-code first
Expand Down Expand Up @@ -310,7 +311,6 @@
(function () {
const tl = gsap.timeline({ paused: true });
const S = "#flowchart-vertical";
const nodePython = document.querySelector(S + " #node-python");
const pythonText = document.querySelector(S + " #python-text");

// 1. Root node scales in
Expand Down Expand Up @@ -381,15 +381,7 @@
tl.to(S + " #cursor", { x: -1110, y: -1560, duration: 1, ease: "power1.inOut" }, "hold3");

// 10. Cursor clicks — selection border
tl.add(() => {
if (!nodePython) return;
if (!nodePython.querySelector(".selection-border")) {
const border = document.createElement("div");
border.className = "selection-border";
nodePython.appendChild(border);
}
gsap.set(S + " .selection-border", { opacity: 1 });
}, "hold3+=1");
tl.set(S + " .selection-border", { opacity: 1 }, "hold3+=1");

tl.to(
S + " #cursor",
Expand Down
12 changes: 2 additions & 10 deletions registry/blocks/flowchart/flowchart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
/>
</svg>
</div>
<div class="selection-border"></div>
</div>
<div id="node-nocode" class="node blue" style="left: 800px; top: 500px">
Try no-code first
Expand Down Expand Up @@ -310,7 +311,6 @@
(function () {
const tl = gsap.timeline({ paused: true });
const S = '[data-composition-id="flowchart"]';
const nodePython = document.querySelector(S + " #node-python");
const pythonText = document.querySelector(S + " #python-text");

// 1. Root node scales in
Expand Down Expand Up @@ -381,15 +381,7 @@
tl.to(S + " #cursor", { x: -1470, y: -540, duration: 1, ease: "power1.inOut" }, "hold3");

// 10. Cursor clicks — selection border
tl.add(() => {
if (!nodePython) return;
if (!nodePython.querySelector(".selection-border")) {
const border = document.createElement("div");
border.className = "selection-border";
nodePython.appendChild(border);
}
gsap.set(S + " .selection-border", { opacity: 1 });
}, "hold3+=1");
tl.set(S + " .selection-border", { opacity: 1 }, "hold3+=1");

tl.to(
S + " #cursor",
Expand Down
Loading