refactor(studio): lift the effect row out of the FX section file

[vanceingalls]

The second extraction. What remains that is not the section's own job is one chain entry's UI — the row, its header, its params, and the automation-key helper that exists only to feed them.

Section is 401 lines now, under the cap. Pure move again.

🤖 Generated with Claude Code

[terencecho]

LGTM. Byte-identical MOVE at ee9f52216c85; single-line delta (function FxNodeRow( → export function FxNodeRow(). Zero hooks/refs/effects in the extracted subtree.

Call site at propertyPanelFxSection.tsx:295-317 is prop-for-prop byte-identical to the base call site — including the load-bearing key={node.id ?? \${node.type}-${i}`}` and its motivating comment.

Tests untouched (propertyPanelFxSection.test.tsx diff = ∅). Extracted behavior stays transitively pinned by the existing 895L section suite via the preserved DOM selectors (hf-fx-node, hf-fx-bypass, hf-fx-move, hf-fx-remove, etc.) and text strings.

OLD-assumption counterfactuals (pinned):

• Key preserves row identity across reorder — keeps a half-typed value ... across a reorder (line 169).
• Bypass toggles without deletion — bypasses without removing (line 152).
• Preview/commit split during drag — previews while dragging and only persists on release (line 423).
• Move-button edge disabling — cannot move the ends past themselves (line 408).
• Preset label wins over def label — shows a preset node by the job it is doing (line 256).

Three invariants (live-automation-values map keying, onAutomate/onRemoveAutomation guard, null-render on unknown type) unpinned at the row seam but low-risk for a byte-identical move.

CI: same pre-existing .md preflight-red as #3181; nothing new to this PR.

— Review by tai (pr-review)

[miga-heygen]

Review: refactor(studio): lift the effect row out of the FX section file — #3182

Verdict: LGTM

Textbook file-extraction refactor. +260/-247 with zero behavioral delta.

• FxNodeRowProps, FxMoveButton, FxNodeHeader, automatedKeysOf, FxNodeParams, FxNodeRow — all byte-identical to the removed code, only FxNodeRow gains the export keyword.
• Import housekeeping correct: old file drops getAudioFxDef, HfAudioFxDef, fxAutomationTarget, FxParams (only used by moved code), retains defaultAudioFxParams which it still uses.
• No hooks were added, removed, or reordered. Component identity and reconciliation behavior unchanged.

Same pattern as #3181, same verdict. Ship it.

---

Review by Miga

🤖 Generated with Claude Code