feat(studio): curve, snap and type a value in an automation lane

.fallowrc.jsonc

@@ -176,6 +176,13 @@
         "withLane",
       ],
     },
+    // propertyPanelAutomation is the shared reader for both panel sections; the
+    // FX group that consumes these two lands one PR upstack, so a per-PR audit
+    // against the merge base sees them as unused.
+    {
+      "file": "packages/studio/src/components/editor/propertyPanelAutomation.ts",
+      "exports": ["automatedTargetsOf", "resolveAutomationRange"],
+    },
     // drawElementService is the bottom of the fast-capture Graphite stack
     // (#1917): its consumers (frameCapture in #1919) land two PRs upstack, so
     // a per-PR audit diffing against the merge base sees these exports as

packages/core/package-subpaths.json

@@ -98,6 +98,12 @@
       "types": "./dist/audioFx.d.ts",
       "environments": ["browser", "bun", "node"]
     },
+    "./audio-fx-tail": {
+      "source": "./src/audio/audioFxTail.ts",
+      "runtime": "./dist/audio/audioFxTail.js",
+      "types": "./dist/audio/audioFxTail.d.ts",
+      "environments": ["browser", "bun", "node"]
+    },
     "./audio-fx-runtime": {
       "source": "./src/generated/audio-fx-runtime-inline.ts",
       "runtime": "./dist/generated/audio-fx-runtime-inline.js",

packages/core/package.json

@@ -112,6 +112,12 @@
       "import": "./src/audioFx.ts",
       "types": "./src/audioFx.ts"
     },
+    "./audio-fx-tail": {
+      "bun": "./src/audio/audioFxTail.ts",
+      "node": "./dist/audio/audioFxTail.js",
+      "import": "./src/audio/audioFxTail.ts",
+      "types": "./src/audio/audioFxTail.ts"
+    },
     "./audio-fx-runtime": {
       "bun": "./src/generated/audio-fx-runtime-inline.ts",
       "node": "./dist/generated/audio-fx-runtime-inline.js",
@@ -396,6 +402,10 @@
         "import": "./dist/audioFx.js",
         "types": "./dist/audioFx.d.ts"
       },
+      "./audio-fx-tail": {
+        "import": "./dist/audio/audioFxTail.js",
+        "types": "./dist/audio/audioFxTail.d.ts"
+      },
       "./audio-fx-runtime": {
         "import": "./dist/generated/audio-fx-runtime-inline.js",
         "types": "./dist/generated/audio-fx-runtime-inline.d.ts"

packages/core/src/audio/audioFxTail.test.ts

@@ -0,0 +1,103 @@
+import { describe, expect, it } from "vitest";
+import { chainTailSeconds, MAX_FX_TAIL_SECONDS } from "./audioFxTail.js";
+import { synthesizeReverbImpulse } from "./audioFxGraph.js";
+import type { HfAudioFxChain } from "../audioFx.js";
+import type { HfAutomation } from "../audioAutomation.js";
+
+const chain = (nodes: HfAudioFxChain["nodes"]): HfAudioFxChain => ({ version: 1, nodes });
+
+describe("chainTailSeconds", () => {
+  it("is zero for a chain that settles with its input", () => {
+    expect(
+      chainTailSeconds(
+        chain([
+          { type: "peaking", id: "n1", params: { frequency: 900, gain: -6, q: 1 } },
+          { type: "compressor", id: "n2", params: { threshold: -18, ratio: 4, release: 9000 } },
+          // A 9-second release still holds no tail: with no input there is no
+          // signal to release, so the output is silence either way.
+          { type: "phaser", id: "n3", params: { delay: 3, decay: 0.4, speed: 0.5 } },
+        ]),
+      ),
+    ).toBe(0);
+  });
+
+  it("matches the reverb impulse it has to make room for", () => {
+    // The whole point: too short and the render cuts the tail the impulse
+    // generates. Measured against the generator rather than restating 0.6+2.6.
+    for (const size of [0.05, 0.4, 0.7, 1]) {
+      const impulse = synthesizeReverbImpulse(48000, size, 0.5);
+      const tail = chainTailSeconds(
+        chain([{ type: "reverb", id: "r", params: { size, damping: 0.5, wet: 0.35, dry: 0.7 } }]),
+      );
+      expect(tail).toBeCloseTo(impulse.length / 48000, 4);
+    }
+  });
+
+  it("counts a delay's repeats down to -60 dB", () => {
+    // 250 ms at 0.35 feedback: 0.35^7 = 6.4e-4, the first repeat under the floor.
+    expect(
+      chainTailSeconds(
+        chain([{ type: "delay", id: "d", params: { time: 250, feedback: 0.35, mix: 0.5 } }]),
+      ),
+    ).toBeCloseTo(1.75, 5);
+  });
+
+  it("sums a serial chain instead of taking the longest", () => {
+    // The delay hands each repeat to the room, so the last repeat still gets a
+    // full tail — taking the max would cut the end of it.
+    const both = chainTailSeconds(
+      chain([
+        { type: "delay", id: "d", params: { time: 250, feedback: 0.35, mix: 0.5 } },
+        { type: "reverb", id: "r", params: { size: 0.3, damping: 0.5, wet: 0.35, dry: 0.7 } },
+      ]),
+    );
+    expect(both).toBeCloseTo(1.75 + (0.6 + 0.3 * 2.6), 5);
+  });
+
+  it("caps a tail the panel can dial but nobody wants to render", () => {
+    // 5 s between repeats at 0.95 feedback decays for eleven minutes.
+    expect(
+      chainTailSeconds(
+        chain([{ type: "delay", id: "d", params: { time: 5000, feedback: 0.95, mix: 1 } }]),
+      ),
+    ).toBe(MAX_FX_TAIL_SECONDS);
+  });
+
+  it("ignores an effect that is bypassed or mixed out", () => {
+    const bypassed = chain([
+      {
+        type: "reverb",
+        id: "r",
+        enabled: false,
+        params: { size: 1, damping: 0.5, wet: 1, dry: 0 },
+      },
+    ]);
+    expect(chainTailSeconds(bypassed)).toBe(0);
+    const silent = chain([
+      { type: "reverb", id: "r", params: { size: 1, damping: 0.5, wet: 0, dry: 1 } },
+    ]);
+    expect(chainTailSeconds(silent)).toBe(0);
+  });
+
+  it("sizes the room for the loudest moment a lane reaches", () => {
+    // Static wet is 0 — read alone it would say "no tail" and cut the swell the
+    // lane brings in halfway through the clip.
+    const automation: HfAutomation = {
+      version: 1,
+      lanes: [
+        {
+          target: "fx.r.wet",
+          points: [
+            { t: 0, v: 0 },
+            { t: 2, v: 0.8 },
+          ],
+        },
+      ],
+    };
+    const withLane = chain([
+      { type: "reverb", id: "r", params: { size: 0.5, damping: 0.5, wet: 0, dry: 1 } },
+    ]);
+    expect(chainTailSeconds(withLane)).toBe(0);
+    expect(chainTailSeconds(withLane, automation)).toBeCloseTo(0.6 + 0.5 * 2.6, 5);
+  });
+});

packages/core/src/audio/audioFxTail.ts

@@ -0,0 +1,96 @@
+/**
+ * How long a chain keeps ringing after its input stops.
+ *
+ * The render used to end the offline context at the last input sample, so a
+ * reverb or a delay was cut mid-tail — the one place the render did not match
+ * preview. The length is not a guess: every tail-producing effect here has a
+ * decay that follows from its own settings, so the render can ask for exactly
+ * the room it needs.
+ */
+
+import { fxAutomationTarget, type HfAutomation } from "../audioAutomation.js";
+import { normalizeAudioFxParams, type HfAudioFxChain, type HfAudioFxNode } from "../audioFx.js";
+
+/**
+ * Ceiling on the extension, in seconds.
+ *
+ * Delay is unbounded in principle: 5 s between repeats at 0.95 feedback decays
+ * for eleven minutes, and the panel can dial exactly that. A tail that outruns
+ * the composition costs render time and mixes into everything after it, so the
+ * chain gets the room it asks for up to here and is cut beyond it.
+ */
+export const MAX_FX_TAIL_SECONDS = 5;
+
+/**
+ * Where a tail stops counting as audible: -60 dB below the signal that fed it,
+ * the usual convention for a reverb time. Anything quieter is under the noise
+ * floor of every codec this renders to.
+ */
+const TAIL_FLOOR = 0.001;
+
+/**
+ * The largest value a knob reaches, over the whole clip.
+ *
+ * A lane's `curve` is an exponent, so a segment is monotone between its two
+ * points and cannot overshoot either — the maximum point value is the maximum
+ * of the lane, no sampling needed. Room size has to be sized for the loudest
+ * moment regardless of where in the clip it falls.
+ */
+function knobMax(node: HfAudioFxNode, key: string, automation?: HfAutomation): number {
+  // Normalised, so a knob missing from the attribute reads as its default and
+  // an out-of-range one is clamped the way the graph builder would clamp it.
+  const fallback = Number(normalizeAudioFxParams(node.type, node.params)[key] ?? 0);
+  if (!node.id || !automation) return Number.isFinite(fallback) ? fallback : 0;
+  const lane = automation.lanes.find((l) => l.target === fxAutomationTarget(node.id ?? "", key));
+  if (!lane || lane.points.length === 0) return Number.isFinite(fallback) ? fallback : 0;
+  return lane.points.reduce((max, p) => Math.max(max, p.v), -Infinity);
+}
+
+/**
+ * Repeats until a feedback loop falls under the floor, times the gap between
+ * them. `feedback` is capped below 1 by the registry, so this terminates.
+ */
+function delayTail(time: number, feedback: number): number {
+  const gap = Math.min(5, time / 1000);
+  if (gap <= 0) return 0;
+  const fb = Math.max(0, Math.min(0.999, feedback));
+  if (fb <= 0) return gap;
+  return Math.ceil(Math.log(TAIL_FLOOR) / Math.log(fb)) * gap;
+}
+
+/** One node's tail. Zero when it has none, or when it is mixed out entirely. */
+function nodeTail(node: HfAudioFxNode, automation?: HfAutomation): number {
+  if (node.enabled === false) return 0;
+  switch (node.type) {
+    case "reverb":
+      // Exactly the generated impulse's length — see synthesizeReverbImpulse,
+      // which is the same expression. A convolution is as long as its impulse.
+      return knobMax(node, "wet", automation) > 0
+        ? 0.6 + Math.max(0, Math.min(1, knobMax(node, "size", automation))) * 2.6
+        : 0;
+    case "delay":
+      return knobMax(node, "mix", automation) > 0
+        ? delayTail(knobMax(node, "time", automation), knobMax(node, "feedback", automation))
+        : 0;
+    case "chorus":
+      // A single delay line, no feedback: it rings for one delay (≤100 ms).
+      return knobMax(node, "mix", automation) > 0 ? knobMax(node, "delay", automation) / 1000 : 0;
+    default:
+      // Everything else settles with its input. The phaser is an all-pass chain
+      // with no recirculation (group delay, not a tail); the dynamics nodes have
+      // long releases but no signal to release — silence in, silence out; a
+      // biquad rings for ~Q/f, which is microseconds.
+      return 0;
+  }
+}
+
+/**
+ * The whole chain's tail, in seconds.
+ *
+ * Summed, not maxed: the chain is serial, so a delay in front of a reverb hands
+ * each of its repeats to the room and the last one still gets a full tail.
+ */
+export function chainTailSeconds(chain: HfAudioFxChain, automation?: HfAutomation): number {
+  const total = chain.nodes.reduce((sum, node) => sum + nodeTail(node, automation), 0);
+  return Math.min(MAX_FX_TAIL_SECONDS, total);
+}

packages/core/stubs/audio-fx-runtime-entry.ts

@@ -19,6 +19,7 @@ import {
 import { scheduleChainAutomation } from "../src/audio/audioFxAutomation.js";
 import { parseAutomation, resolveAutomation } from "../src/audioAutomation.js";
 import { parseAudioFxChain, type HfAudioFxChain } from "../src/audioFx.js";
+import { chainTailSeconds } from "../src/audio/audioFxTail.js";
 
 declare global {
   interface Window {
@@ -39,11 +40,11 @@ declare global {
  * Channel count is preserved: folding to mono here collapsed a stereo bed's
  * width for the render only, while preview kept it stereo.
  *
- * The context is exactly as long as the input. An effect with a tail — reverb,
- * delay — is still ringing at that point and is cut there, which is the one place
- * the render does not match preview. Extending it would lengthen the clip in the
- * mix, so how far a tail may run past a clip's end is a product decision rather
- * than something to pick here.
+ * The context runs past the input by the chain's own tail, so a reverb or a
+ * delay decays out instead of being cut at the last input sample. The length
+ * comes from the settings (`chainTailSeconds`), capped, and the returned planes
+ * are correspondingly longer than what came in — the mixer decides how much of
+ * that it lets through past the clip's end.
  */
 
 /** The clip's audio as an AudioBuffer, a plane per channel. */
@@ -80,7 +81,11 @@ async function render(
   const chain: HfAudioFxChain = parseAudioFxChain(chainJson);
   const channels = Math.max(1, planes.length);
   const frames = planes[0]?.length ?? 0;
-  const ctx = new OfflineAudioContext(channels, frames, sampleRate);
+  const parsedAutomation = automationJson
+    ? resolveAutomation(parseAutomation(automationJson), chain)
+    : null;
+  const tail = Math.ceil(chainTailSeconds(chain, parsedAutomation ?? undefined) * sampleRate);
+  const ctx = new OfflineAudioContext(channels, frames + tail, sampleRate);
 
   if (chainNeedsWorklets(chain)) await ensureAudioFxWorklets(ctx);
 
@@ -92,9 +97,8 @@ async function render(
   // The input WAV is the clip's own audio from its first sample, so clip-local
   // time is offline time — the envelope needs no offset here. Same scheduler as
   // preview, which is what makes the two agree.
-  if (automationJson) {
-    const automation = resolveAutomation(parseAutomation(automationJson), chain);
-    scheduleChainAutomation(automation, chain, fx.nodes, {
+  if (parsedAutomation) {
+    scheduleChainAutomation(parsedAutomation, chain, fx.nodes, {
       scheduledAt: 0,
       elapsed: 0,
       rate: 1,