Skip to content

revert(producer): drop renderStretch fit_to_scene retime (#2676) - #2730

Merged
xuanruli merged 1 commit into
mainfrom
revert-renderstretch-2676
Jul 22, 2026
Merged

revert(producer): drop renderStretch fit_to_scene retime (#2676)#2730
xuanruli merged 1 commit into
mainfrom
revert-renderstretch-2676

Conversation

@xuanruli

Copy link
Copy Markdown
Contributor

Reverts #2676 (renderStretch).

Why

renderStretch tried to fix the fit_to_scene stutter (a composition shorter than its scene is frame-held by the compositor) by re-timing the GSAP timeline at render: emit target-length output and scale the per-frame seek across [0, intrinsic]. Local render tests show this cannot work — seeking a 1s-authored timeline more finely does not create new motion. The extra output frames are near-duplicates of their neighbours (sub-pixel deltas collapse on capture), so a 1s composition still yields ~30 distinct frames regardless of renderStretch. Measured: a 1s composition renders 30 unique frames at 30fps and stays ~30 unique under renderStretch; only 118 unique at a native 120fps render.

What replaces it

The correct fix needs no producer change: the producer already honours the fps override, and rendering a short composition at a scene-scaled fps (ceil(output_fps * scene / intrinsic)) produces genuinely distinct frames that fill the stretched clip. That lives entirely in experiment-framework (#42766) — it computes the fps and passes it through the existing fps field. No renderStretch plumbing required.

Ref: VA-1859.

@xuanruli xuanruli changed the title Revert "feat(producer): renderStretch to re-time short compositions across longer scenes (#2676)" revert(producer): drop renderStretch fit_to_scene retime (#2676) Jul 22, 2026
@xuanruli
xuanruli merged commit 69446e7 into main Jul 22, 2026
78 of 89 checks passed
@xuanruli
xuanruli deleted the revert-renderstretch-2676 branch July 22, 2026 02:39
jrusso1020 added a commit that referenced this pull request Jul 27, 2026
## What

Adds the weekly digest entry for July 20 to July 27, 2026 to `docs/weekly-updates.mdx`.

Generated with `bun run changelog:weekly --from 2026-07-20 --to 2026-07-27 --write`, then rewritten to publish quality: entries grouped under Features, Fixes, and Docs, prose rewritten to describe user impact, and the `<!-- TODO: review -->` marker removed.

## Why

Keeps the public weekly-updates page current. The digest is the RSS-backed summary readers get between versioned releases.

## How

- Ran the generator over the July 20 to July 27 range.
- Rewrote the new `<Update>` block: 11 Features, 15 Fixes, 3 Docs bullets.
- Every commit and PR link the generator produced for these entries is retained. No link was invented; all references trace back to `updates/weekly/2026-07-27.md`.
- Headline items: professional color grading across core, Studio, and the CLI; a versioned distributed plan protocol with direct S3 and GCS publishing; the Studio keyframe ease editor; data-driven registry caption components.
- `renderStretch` (#2676) is deliberately omitted, since it was reverted in the same window by #2730 and is not present at HEAD.
- CI-only performance and internal refactor entries are omitted as not user-facing.

## Test plan

Docs-only change. No runtime code touched.

- [ ] Unit tests added/updated
- [x] Manual testing performed
- [x] Documentation updated (if applicable)

Verification performed:
- `git diff origin/main --stat` shows only `docs/weekly-updates.mdx`, 49 insertions and 0 deletions (purely additive, the prior week's entry is untouched).
- Confirmed the TODO marker is gone from the file.
- Confirmed every commit SHA and PR number in the new block appears in the generator's own draft, and that each link label matches its href.
- Confirmed the block contains no em-dashes and no stray JSX-unsafe characters outside inline code.
- `node scripts/check-tracked-artifacts.mjs` passes.
dahans-msft2 pushed a commit to dahans-msft2/hyperframes that referenced this pull request Aug 6, 2026
dahans-msft2 pushed a commit to dahans-msft2/hyperframes that referenced this pull request Aug 6, 2026
## What

Adds the weekly digest entry for July 20 to July 27, 2026 to `docs/weekly-updates.mdx`.

Generated with `bun run changelog:weekly --from 2026-07-20 --to 2026-07-27 --write`, then rewritten to publish quality: entries grouped under Features, Fixes, and Docs, prose rewritten to describe user impact, and the `<!-- TODO: review -->` marker removed.

## Why

Keeps the public weekly-updates page current. The digest is the RSS-backed summary readers get between versioned releases.

## How

- Ran the generator over the July 20 to July 27 range.
- Rewrote the new `<Update>` block: 11 Features, 15 Fixes, 3 Docs bullets.
- Every commit and PR link the generator produced for these entries is retained. No link was invented; all references trace back to `updates/weekly/2026-07-27.md`.
- Headline items: professional color grading across core, Studio, and the CLI; a versioned distributed plan protocol with direct S3 and GCS publishing; the Studio keyframe ease editor; data-driven registry caption components.
- `renderStretch` (heygen-com#2676) is deliberately omitted, since it was reverted in the same window by heygen-com#2730 and is not present at HEAD.
- CI-only performance and internal refactor entries are omitted as not user-facing.

## Test plan

Docs-only change. No runtime code touched.

- [ ] Unit tests added/updated
- [x] Manual testing performed
- [x] Documentation updated (if applicable)

Verification performed:
- `git diff origin/main --stat` shows only `docs/weekly-updates.mdx`, 49 insertions and 0 deletions (purely additive, the prior week's entry is untouched).
- Confirmed the TODO marker is gone from the file.
- Confirmed every commit SHA and PR number in the new block appears in the generator's own draft, and that each link label matches its href.
- Confirmed the block contains no em-dashes and no stray JSX-unsafe characters outside inline code.
- `node scripts/check-tracked-artifacts.mjs` passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants