fix(parsers): read fragment composition metadata - #2536
Closed
tianma-if wants to merge 1 commit into
Closed
Conversation
miguel-heygen
approved these changes
Jul 16, 2026
Contributor
|
Closing — this PR has been inactive for an extended period. Thank you for the contribution! Please feel free to reopen if you'd like to continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
<html>element has no composition attributes.<template>are supported.Why
Template and fragment sub-compositions follow the dual-carrier contract introduced in #2081: their metadata may live on the inner
[data-composition-id]root rather than<html>.extractCompositionMetadata()only read<html>, so CLI variable validation saw an empty schema for otherwise valid sub-composition files.Validation
bunx oxlint packages/parsers/src/htmlParser.ts packages/parsers/src/htmlParser.test.tsbun run --filter @hyperframes/parsers test -- htmlParser.test.tsbun run --filter @hyperframes/parsers typecheckgit diff --check