Skip to content

fix(studio): preserve playhead position on composition refresh #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguel-heygen merged 3 commits into from
May 21, 2026
Merged

fix(studio): preserve playhead position on composition refresh #1000

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e9a175
fix(studio): preserve playhead position on composition refresh
miguel-heygen May 21, 2026
afa6530
refactor(studio): remove dead crossfade scaffolding from NLEPreview
miguel-heygen May 21, 2026
e2de547
feat(studio): auto-reveal source when selecting elements in Code tab
miguel-heygen May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/studio/src/components/nle/NLEPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ export const NLEPreview = memo(function NLEPreview({
suppressLoadingOverlay,
}: NLEPreviewProps) {
const baseKey = getPreviewPlayerKey({ projectId, directUrl, refreshKey });
const prevRefreshKeyRef = useRef(refreshKey);
const viewportRef = useRef<HTMLDivElement>(null);
const stageRef = useRef<HTMLDivElement>(null);
const [retiringKey, setRetiringKey] = useState<string | null>(null);
Expand Down Expand Up @@ -205,13 +204,7 @@ export const NLEPreview = memo(function NLEPreview({
[applyTransform],
);

if (refreshKey !== prevRefreshKeyRef.current) {
const oldKey = `${baseKey}:${prevRefreshKeyRef.current ?? 0}`;
prevRefreshKeyRef.current = refreshKey;
setRetiringKey(oldKey);
}

const activeKey = `${baseKey}:${refreshKey ?? 0}`;
const activeKey = baseKey;

const applyInitialZoom = useCallback(() => {
const z = zoomRef.current;
Expand Down
Loading