(WIP) refactor gpu allocator selection for vulkan #1417
+18
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unsure why the function to select the optimal allocator was causing an issue, changed it something simpler but working to get the examples running and so i could work on testing swapchain recreation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure why the function to select the optimal allocator was causing an issue, changed it something simpler but working to get the examples running and so i could work on testing swapchain recreation
Seems like an interaction with nvidia and vulkan specifically, will try to understand what the original was doing better and why it was causing this error for me: #1352 so ideally the changes are smaller and I'm still using the same checks as before for selecting an allocator.