Skip to content

Fix for vulkan sysgpu backend when only some attachments are cleared #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for vulkan sysgpu backend when only some attachments are cleared #1339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77cf4c3
Fix for vulkan sysgpu backend when only some attachments are cleared
platypro Jan 27, 2025
37788bf
Merge branch 'hexops:main' into vulkan-clear-fix
platypro Feb 10, 2025
24ad69e
Merge branch 'hexops:main' into vulkan-clear-fix
platypro Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions src/sysgpu/vulkan.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3181,18 +3181,16 @@ pub const RenderPassEncoder = struct {
} else null,
});

if (attach.load_op == .clear) {
try clear_values.append(.{
.color = .{
.float_32 = [4]f32{
@floatCast(attach.clear_value.r),
@floatCast(attach.clear_value.g),
@floatCast(attach.clear_value.b),
@floatCast(attach.clear_value.a),
},
try clear_values.append(.{
.color = .{
.float_32 = [4]f32{
@floatCast(attach.clear_value.r),
@floatCast(attach.clear_value.g),
@floatCast(attach.clear_value.b),
@floatCast(attach.clear_value.a),
},
});
}
},
});

extent = view.extent;
}
Expand All @@ -3216,14 +3214,12 @@ pub const RenderPassEncoder = struct {
.read_only = attach.depth_read_only == .true or attach.stencil_read_only == .true,
};

if (attach.depth_load_op == .clear or attach.stencil_load_op == .clear) {
try clear_values.append(.{
.depth_stencil = .{
.depth = attach.depth_clear_value,
.stencil = attach.stencil_clear_value,
},
});
}
try clear_values.append(.{
.depth_stencil = .{
.depth = attach.depth_clear_value,
.stencil = attach.stencil_clear_value,
},
});

extent = view.extent;
}
Expand Down
Loading