Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: refactor: refactor types #5483
base: master
Are you sure you want to change the base?
WIP: refactor: refactor types #5483
Changes from all commits
88e252d
5d0ae13
2ebf78a
d2ba290
f2e2326
fa58a32
04f141c
7da718b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 62 in lib/extend/tag.ts
GitHub Actions / linter
Check warning on line 62 in lib/extend/tag.ts
GitHub Actions / linter
Check warning on line 83 in lib/extend/tag.ts
GitHub Actions / linter
Check warning on line 83 in lib/extend/tag.ts
GitHub Actions / linter
Check warning on line 90 in lib/extend/tag.ts
GitHub Actions / linter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use TypeScript definition only, the JSDoc types can be omitted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's improve the
warehouse
'svirtual
type to inferthis
here.