refactor: refactor types #5271
Merged
refactor: refactor types #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b v7.0.0_7 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 6655790130
💛 - Coveralls |
stevenjoezhang
previously approved these changes
Aug 23, 2023
renbaoshuo
reviewed
Aug 23, 2023
SukkaW
reviewed
Aug 24, 2023
SukkaW
reviewed
Oct 23, 2023
SukkaW
reviewed
Oct 23, 2023
SukkaW
reviewed
Oct 23, 2023
SukkaW
reviewed
Oct 23, 2023
SukkaW
reviewed
Oct 23, 2023
|
There are still many types that are any and we need more work after the v7.0.0 release |
|
maybe we should refactor the type of warehouse first...... |
SukkaW
previously approved these changes
Oct 26, 2023
D-Sketon
dismissed
SukkaW’s stale review
The merge-base changed after approval.
|
The rebase is done. You can merge at any time.😎 |
SukkaW
previously approved these changes
Oct 27, 2023
D-Sketon
commented
Oct 28, 2023
| @@ -61,7 +61,7 @@ function timeTagHelper(date: string | number | Date | moment.Moment, format: str | |||
| return `<time datetime="${toISOString(date)}">${this.date(date, format, getLanguage(this), config.timezone)}</time>`; | |||
| } | |||
|
|
|||
| function getLanguage(ctx: Hexo) { | |||
| function getLanguage(ctx) { | |||
There was a problem hiding this comment.
ctx is not Hexo but Locals with helpers
uiolee
approved these changes
Oct 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Screenshots
Pull request tasks