fix(#5053): exclude data-uri image for og:image (#5053)

hexojs · Sep 7, 2022 · 06a8ebb · 06a8ebb
1 parent 6deeb8d
commit 06a8ebb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/plugins/helper/open_graph.js b/lib/plugins/helper/open_graph.js
@@ -115,7 +115,8 @@ function openGraphHelper(options = {}) {
     result += og('og:locale', localeToTerritory(language), false);
   }
 
-  images = images.map(path => new URL(path, url || config.url).toString());
+  images = images.map(path => new URL(path, url || config.url).toString())
+    .filter(url => !url.startsWith('data:'));
 
   images.forEach(path => {
     result += og('og:image', path, false);

diff --git a/test/scripts/helpers/open_graph.js b/test/scripts/helpers/open_graph.js
@@ -211,6 +211,18 @@ describe('open_graph', () => {
     result.should.have.string(meta({property: 'og:image', content: 'https://hexo.io/test.jpg'}));
   });
 
+  it('images - content with data-uri', () => {
+    const result = openGraph.call({
+      page: {
+        content: '<img src="data:image/svg+xml;utf8,<svg>...</svg>">'
+      },
+      config: hexo.config,
+      is_post: isPost
+    });
+
+    result.should.not.have.string(meta({property: 'og:image', content: 'data:image/svg+xml;utf8,<svg>...</svg>'}));
+  });
+
   it('images - string', () => {
     const result = openGraph.call({
       page: {