Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate typescript #418

Merged
merged 10 commits into from
Nov 9, 2022
Merged

refactor: migrate typescript #418

merged 10 commits into from
Nov 9, 2022

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Oct 31, 2022 •
edited
Loading

There are some types missing in hexo-fs and graceful-fs. I'll work on the upstream first.

See hexojs/hexo-fs#109

"types" in package.json may be incorrect

@coveralls
Copy link

coveralls commented Nov 5, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 84.211% when pulling cff8ea6 on ts into 6d722a2 on master.

@stevenjoezhang stevenjoezhang marked this pull request as ready for review November 5, 2022 15:54
@stevenjoezhang stevenjoezhang changed the title refactor: migrate typescript (WIP) refactor: migrate typescript Nov 5, 2022
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 5, 2022
Merged
@stevenjoezhang stevenjoezhang requested a review from a team November 7, 2022 13:53
yoshinorin
yoshinorin reviewed Nov 9, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@stevenjoezhang @yoshinorin
update package.json
cff8ea6 
Co-authored-by: yoshinorin <[email protected]>
yoshinorin
yoshinorin approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@stevenjoezhang stevenjoezhang merged commit 8c5d506 into master Nov 9, 2022
@GhostDog98 GhostDog98 mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenjoezhang @coveralls @yoshinorin