Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add per resource list actions endpoints #521

Closed
wants to merge 1 commit into from

Conversation

jooola
Copy link
Member

@jooola jooola commented Aug 27, 2024

No description provided.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 70.81%. Comparing base (743eabb) to head (be3a84b).

Files Patch % Lines
hcloud/action.go 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   71.46%   70.81%   -0.65%     
==========================================
  Files          46       46              
  Lines        3935     3971      +36     
==========================================
  Hits         2812     2812              
- Misses        710      746      +36     
  Partials      413      413              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Member Author

jooola commented Aug 28, 2024

Closing, as it is not as useful as I thought. The actions returned by those endpoints are strictly scoped to the resource type.

e.g. one cannot query firewall apply actions that are being applied on a specific server via the /servers/<server_id>/actions endpoint. The /firewalls/actions endpoint must be queried and the result filtered client side.

@jooola jooola closed this Aug 28, 2024
@jooola jooola deleted the feat--add-per-resource-list-actions-endpoints branch August 28, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant