Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid_input API errors may not return details [Backport release-1.x] #508

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2024

The create uploaded certificate endpoint may return the following error:

{
  "error": {
    "code": "invalid_input",
    "message": "certificate must use larger key size"
  }
}

This change ensure that we do not get a json unmarshal error (unexpected end of json) while trying to parse a non-existing details data.


Backport ca78af2 from #507.

BEGIN_COMMIT_OVERRIDE
fix: invalid_input API errors may not return details
END_COMMIT_OVERRIDE

The create uploaded certificate endpoint may return the following error:

```
{
  "error": {
    "code": "invalid_input",
    "message": "certificate must use larger key size"
  }
}
```

This change ensure that we do not get a json unmarshal error (unexpected
end of json) while trying to parse a non-existing details data.

(cherry picked from commit ca78af2)
@github-actions github-actions bot requested a review from a team as a code owner August 9, 2024 13:02
@jooola jooola merged commit bfa3803 into release-1.x Aug 9, 2024
@jooola jooola deleted the backport-507-to-release-1.x branch August 9, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant