fix: LoadBalancerUpdateServiceOpts not converted correctly #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the conversion from LoadBalancerUpdateServiceOpts to schema.LoadBalancerActionUpdateServiceRequest, there are conversions from slices to slice pointers. Slice pointers exist in schemas to differentiate between absent and empty. Goverter converts nil slices to &nil. This leads to the field being marshaled to `null` in JSON (even with the `omitempty` flag) instead of being not present (See hetznercloud/cli#702) This PR fixes this issue by adding manual conversion methods
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
- Coverage 80.35% 80.34% -0.02%
==========================================
Files 32 32
Lines 5722 5718 -4
==========================================
- Hits 4598 4594 -4
Misses 717 717
Partials 407 407 ☔ View full report in Codecov by Sentry. |
jooola
reviewed
Mar 5, 2024
jooola
approved these changes
Mar 5, 2024
phm07
force-pushed
the
fix-loadbalancer-update-service-opts-schema
branch
from
0e28a30
to
8353c9b
Compare
apricote
pushed a commit
that referenced
this pull request
Mar 27, 2024
🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.0...v2.7.0) (2024-03-27) ### Features * add volume format property ([#397](#397)) ([c0940af](c0940af)) * **error:** handle wrapped errors in IsError() ([#374](#374)) ([83df108](83df108)) * require Go >= 1.20 ([#392](#392)) ([299f181](299f181)) * **server:** deprecate ServerRescueTypeLinux32 ([#378](#378)) ([2f334c3](2f334c3)) * test with Go 1.22 ([#391](#391)) ([49be506](49be506)) ### Bug Fixes * falsely omitted fields in firewall schema ([#396](#396)) ([a3509b6](a3509b6)) * LoadBalancerUpdateServiceOpts not converted correctly ([#394](#394)) ([0f187ce](0f187ce)) * primary ip assignee id not mapped to nil ([#395](#395)) ([b5fea38](b5fea38)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Sep 12, 2024
…etznercloud/fleeting-plugin-hetzner!38) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.6.0` -> `v2.7.2` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.7.2`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.2) [Compare Source](hetznercloud/hcloud-go@v2.7.1...v2.7.2) ##### Bug Fixes - creating firewall with rules not working correctly ([#​412](hetznercloud/hcloud-go#412)) ([43b2bab](hetznercloud/hcloud-go@43b2bab)) ### [`v2.7.1`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.1) [Compare Source](hetznercloud/hcloud-go@v2.7.0...v2.7.1) ##### Bug Fixes - setting firewall rules not working correctly ([#​405](hetznercloud/hcloud-go#405)) ([16daea0](hetznercloud/hcloud-go@16daea0)) ### [`v2.7.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.7.0) [Compare Source](hetznercloud/hcloud-go@v2.6.0...v2.7.0) ##### Features - add volume format property ([#​397](hetznercloud/hcloud-go#397)) ([c0940af](hetznercloud/hcloud-go@c0940af)) - **error:** handle wrapped errors in IsError() ([#​374](hetznercloud/hcloud-go#374)) ([83df108](hetznercloud/hcloud-go@83df108)) - require Go >= 1.20 ([#​392](hetznercloud/hcloud-go#392)) ([299f181](hetznercloud/hcloud-go@299f181)) - **server:** deprecate ServerRescueTypeLinux32 ([#​378](hetznercloud/hcloud-go#378)) ([2f334c3](hetznercloud/hcloud-go@2f334c3)) - test with Go 1.22 ([#​391](hetznercloud/hcloud-go#391)) ([49be506](hetznercloud/hcloud-go@49be506)) ##### Bug Fixes - falsely omitted fields in firewall schema ([#​396](hetznercloud/hcloud-go#396)) ([a3509b6](hetznercloud/hcloud-go@a3509b6)) - LoadBalancerUpdateServiceOpts not converted correctly ([#​394](hetznercloud/hcloud-go#394)) ([0f187ce](hetznercloud/hcloud-go@0f187ce)) - primary ip assignee id not mapped to nil ([#​395](hetznercloud/hcloud-go#395)) ([b5fea38](hetznercloud/hcloud-go@b5fea38)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjQuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the conversion from LoadBalancerUpdateServiceOpts to schema.LoadBalancerActionUpdateServiceRequest, there are conversions from slices to slice pointers. Slice pointers exist in schemas to differentiate between absent and empty.
Goverter converts nil slices to &nil. This leads to the field being marshaled to
nullin JSON (even with theomitemptyflag) instead of being not present (See hetznercloud/cli#702)This PR fixes this issue by adding manual conversion methods and adds tests to account for this behavior.