feat: alias deprecated field to deprecation info struct #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage ? 76.46%
=======================================
Files ? 32
Lines ? 6726
Branches ? 0
=======================================
Hits ? 5143
Misses ? 1176
Partials ? 407 ☔ View full report in Codecov by Sentry. |
|
Why do we keep |
jooola
force-pushed
the
deprecated-alias
branch
from
e869fe1
to
7bad12d
Compare
phm07
approved these changes
Jan 9, 2024
jooola
added
backport release-1.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-371-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e961be9615452fc63c4c71e6561d4e86f8e8e95a
# Push it to GitHub
git push --set-upstream origin backport-371-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.xThen, create a pull request where the |
|
We cannot back port this change because the goverter change was not implemented in v1, please ignore this warning. |
jooola
pushed a commit
that referenced
this pull request
Jan 9, 2024
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.1...v2.6.0) (2024-01-09) ### Features * alias deprecated field to deprecation info struct ([#371](#371)) ([e961be9](e961be9)) * **instrumentation:** allow passing in any prometheus.Registerer ([#369](#369)) ([0821c07](0821c07)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jooola
added a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to mitigate the removal of the deprecated field from the API, by linking the
deprecatedfield value to the deprecation info object.