feat: support resource-specific Action endpoints #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apricote
force-pushed
the
product-specific-actions
branch
from
0891048
to
a473187
Compare
apricote
force-pushed
the
product-specific-actions
branch
from
a473187
to
ba2b4f8
Compare
apricote
added
Feature
backport release-1.x
jooola
approved these changes
Aug 24, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.x release-1.x
# Navigate to the new working tree
cd .worktrees/backport-release-1.x
# Create a new branch
git switch --create backport-295-to-release-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ddc2ac45489c48a7563806c425222236ab1f8aa0
# Push it to GitHub
git push --set-upstream origin backport-295-to-release-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.xThen, create a pull request where the |
apricote
added a commit
that referenced
this pull request
Aug 24, 2023
Related to https://docs.hetzner.cloud/changelog#2023-06-29-resource-action-endpoints The existing ActionClient has two purposes: - Expose the GET /v1/actions & GET /v1/actions/:id endpoints - Provider helper methods for waiting on running actions The new resource-specific endpoints do not need the helper methods, so I have refactored the code for the endpoints into the ResourceActionClient. This client is exposed by all resources that have actions as client.Server.Action. In addition, I have replaced the implementation of the two endpoints in ActionClient by forwarding them to an instance of ResourceActionClient. (cherry picked from commit ddc2ac4)
apricote
added a commit
that referenced
this pull request
Aug 24, 2023
Related to https://docs.hetzner.cloud/changelog#2023-06-29-resource-action-endpoints The existing ActionClient has two purposes: - Expose the GET /v1/actions & GET /v1/actions/:id endpoints - Provider helper methods for waiting on running actions The new resource-specific endpoints do not need the helper methods, so I have refactored the code for the endpoints into the ResourceActionClient. This client is exposed by all resources that have actions as client.Server.Action. In addition, I have replaced the implementation of the two endpoints in ActionClient by forwarding them to an instance of ResourceActionClient. (cherry picked from commit ddc2ac4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://docs.hetzner.cloud/changelog#2023-06-29-resource-action-endpoints
The existing
ActionClienthas two purposes:GET /v1/actions&GET /v1/actions/:idendpointsThe new resource-specific endpoints do not need the helper methods, so I have refactored the code for the endpoints into the
ResourceActionClient. This client is exposed by all resources that have actions asclient.Server.Action. In addition, I have replaced the implementation of the two endpoints inActionClientby forwarding them to an instance ofResourceActionClient.