Make old ratelimit error code work as expected (#74)

* Make old ratelimit error code work as expected

Fixes #73.

* Use new RateLimitExceededCode in ActionClient

CHANGES.md

@@ -1,5 +1,10 @@
 # Changes
 
+## master
+
+* Make clients using the old error code for ratelimiting work as expected
+  ([issue #73](https://github.com/hetznercloud/hcloud-go/issues/73))
+
 ## v1.3.0
 
 * Support passing user data on server creation ([issue #70](https://github.com/hetznercloud/hcloud-go/issues/70))

hcloud/action.go

@@ -170,7 +170,7 @@ func (c *ActionClient) WatchProgress(ctx context.Context, action *Action) (<-cha
 
 			action, _, err := c.GetByID(ctx, action.ID)
 			if err != nil {
-				if err, ok := err.(Error); ok && err.Code == ErrorCodeLimitReached {
+				if err, ok := err.(Error); ok && err.Code == ErrorCodeRateLimitExceeded {
 					c.client.backoff(retries)
 					retries++
 					continue

hcloud/action_test.go

@@ -156,7 +156,7 @@ func TestActionClientWatchProgress(t *testing.T) {
 			w.WriteHeader(http.StatusTooManyRequests)
 			json.NewEncoder(w).Encode(schema.ErrorResponse{
 				Error: schema.Error{
-					Code:    "limit_reached",
+					Code:    ErrorCodeRateLimitExceeded,
 					Message: "ratelimited",
 				},
 			})

hcloud/error.go

@@ -14,7 +14,13 @@ const (
 	ErrorCodeInvalidInput                = "invalid_input"       // Validation error
 
 	// Deprecated error codes
-	ErrorCodeLimitReached = "limit_reached"
+
+	// The actual value of this error code is limit_reached. The new error code
+	// rate_limit_exceeded for ratelimiting was introduced before Hetzner Cloud
+	// launched into the public. To make clients using the old error code still
+	// work as expected, we set the value of the old error code to that of the
+	// new error code.
+	ErrorCodeLimitReached = ErrorCodeRateLimitExceeded
 )
 
 // Error is an error returned from the API.