fix(primary-ip): labels ignored in create command #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=======================================
Coverage 69.23% 69.23%
=======================================
Files 244 244
Lines 10638 10640 +2
=======================================
+ Hits 7365 7367 +2
Misses 2605 2605
Partials 668 668
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
Oct 24, 2024
phm07
pushed a commit
that referenced
this pull request
Oct 25, 2024
🤖 I have created a release *beep* *boop* --- ## [1.48.0](v1.47.0...v1.48.0) (2024-10-25) ### Features * allow auto-completing context flag ([#861](#861)) ([7495b14](7495b14)) * **primary-ip:** allow setting auto-delete on create ([#860](#860)) ([b6aecb3](b6aecb3)), closes [#855](#855) ### Bug Fixes * **image:** only use numerical IDs for label auto-completion ([#865](#865)) ([1d10d92](1d10d92)) * **primary-ip:** labels ignored in create command ([#885](#885)) ([7a17174](7a17174)), closes [#883](#883) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing functionality to add labels when creating a Primary IP and also adds it to the unit tests.
Fixes #883