Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(image): only use numerical IDs for label auto-completion #865

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix(image): only use numerical IDs for label auto-completion #865

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb85da
fix(image): only use numerical IDs for label auto-completion
phm07 Sep 6, 2024
a138da5
image might not exist
phm07 Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions internal/hcapi2/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,14 @@ func (c *imageClient) Names() []string {
return names
}

// ImageLabelKeys returns a slice containing the keys of all labels assigned to
// the Image with the passed idOrName.
func (c *imageClient) LabelKeys(idOrName string) []string {
img, _, err := c.Get(context.Background(), idOrName)
// LabelKeys returns a slice containing the keys of all labels assigned to
// the Image with the passed id.
func (c *imageClient) LabelKeys(id string) []string {
imgID, err := strconv.ParseInt(id, 10, 64)
if err != nil {
return nil
}
img, _, err := c.GetByID(context.Background(), imgID)
if err != nil || img == nil || len(img.Labels) == 0 {
return nil
}
Expand Down