Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to label servers, volumes, images, floating ips and ssh keys on creation #227

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Add option to label servers, volumes, images, floating ips and ssh keys on creation #227

merged 2 commits into from
Feb 20, 2020

Conversation

jawher
Copy link
Contributor

@jawher jawher commented Feb 19, 2020

This way, servers can be labeled at creation time.

Example usage:

hcloud server create \
	--image=$image \
	--datacenter=nbg1-dc3 \
	--type=cx21 \
	--label project=cloud --label stage=test \
	--name=db-replica-1

@jawher jawher force-pushed the add-label-to-craete-server branch from f12f52f to c43cf9e Compare February 19, 2020 00:28
@LKaemmerling
Copy link
Member

Thank you for your contribution! Would it be possible that you rebase your PR and add the option to floating-ip create, volume create, ssh-key create and network create too?

@jawher
Copy link
Contributor Author

jawher commented Feb 19, 2020

@LKaemmerling Thank you for the prompt response, and sure thing 👍

@jawher
Add --label option to create server command
6db2384 
This way, servers can be labeled at the creation time.

Example usage:

```
hcloud server create \
	--image=$image \
	--datacenter=nbg1-dc3 \
	--type=cx21 \
	--label project=cloud --label stage=test \
	--name=db-replica-1
```
@jawher
Add --label to floating-ip, server-image, ssh-key, network and volume…
d858d81 
… create commands
@jawher jawher force-pushed the add-label-to-craete-server branch from c43cf9e to d858d81 Compare February 19, 2020 15:12
@jawher jawher changed the title Add --label option to create server command Add --label option to create server, server-iamge, ssh0key, floating-ip and network commands Feb 19, 2020
@jawher jawher changed the title Add --label option to create server, server-iamge, ssh0key, floating-ip and network commands Add --label option to create server, server-image, ssh-key, floating-ip and network commands Feb 19, 2020
@jawher jawher changed the title Add --label option to create server, server-image, ssh-key, floating-ip and network commands Add --label option to create server, server-image, ssh-key, floating-ip, network and volume commands Feb 19, 2020
@LKaemmerling LKaemmerling reopened this Feb 20, 2020
@LKaemmerling
Copy link
Member

(Closed and reopened because i wanted to trigger Github Actions)

@LKaemmerling LKaemmerling changed the title Add --label option to create server, server-image, ssh-key, floating-ip, network and volume commands Add option to label servers, volumes, images, floating ips and ssh keys on creation Feb 20, 2020
@LKaemmerling LKaemmerling self-requested a review February 20, 2020 05:54
LKaemmerling
LKaemmerling approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@LKaemmerling LKaemmerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you!

@LKaemmerling LKaemmerling merged commit 613eafc into hetznercloud:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKaemmerling LKaemmerling LKaemmerling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jawher @LKaemmerling