Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCLOUD_TOKEN not working when creating context #576

Closed
Sathylias opened this issue Oct 21, 2023 · 2 comments · Fixed by #582 or #583
Closed

HCLOUD_TOKEN not working when creating context #576

Sathylias opened this issue Oct 21, 2023 · 2 comments · Fixed by #582 or #583
Assignees
@phm07

Comments

@Sathylias
Copy link

Sathylias commented Oct 21, 2023 •
edited
Loading

Hey there,

Currently using latest version (hcloud 1.38.3), but having some issues creating a context while using the HCLOUD_TOKEN environment variable. Even if the variable is correctly defined and I run 'hcloud context create testing', it still prompts me for the token.

Anyone having the same issue ?

EDIT: After reading 'context.go', I don't even think it's reading that environment variable. Mind you, I didn't have my coffee yet, so please correct me if I'm wrong.
@phm07 phm07 self-assigned this Oct 25, 2023
phm07 added a commit that referenced this issue Oct 25, 2023
@phm07
feat(context): ask to use HCLOUD_TOKEN when creating new context
50441b2 
As requested in #576
@phm07 phm07 mentioned this issue Oct 25, 2023
Merged
@phm07
Copy link
Contributor

phm07 commented Oct 25, 2023

Originally when creating a context you were only able to enter the API token interactively. #582 implements your suggestion, as it will ask you if you want to use the token from HCLOUD_TOKEN when creating a new context.

phm07 added a commit that referenced this issue Oct 25, 2023
@phm07
feat(context): ask to use HCLOUD_TOKEN when creating new context (#582)
54e582a 
Closes #576
@hcloud-bot hcloud-bot mentioned this issue Oct 25, 2023
Merged
@Sathylias
Copy link
Author

Amazing, thank you for looking into it @pauhull, much appreciated!

phm07 pushed a commit that referenced this issue Nov 14, 2023
@hcloud-bot
chore(main): release 1.40.0 (#583)
1143e07 
🤖 I have created a release *beep* *boop*
---


##
[1.40.0](v1.39.0...v1.40.0)
(2023-11-14)


### Features

* add warning messages to context commands
([#605](#605))
([d84fe36](d84fe36)),
closes [#588](#588)
* allow JSON output on resource creation
([#609](#609))
([d7241fe](d7241fe)),
closes [#470](#470)
* **context:** ask to use HCLOUD_TOKEN when creating new context
([#582](#582))
([54e582a](54e582a)),
closes [#576](#576)
* pretty-print JSON output
([#610](#610))
([ca4706f](ca4706f))
* print out IPs after they were created
([#590](#590))
([0e0eaa8](0e0eaa8))


### Bug Fixes

* "create" actions were not awaited in some cases
([#589](#589))
([1c0e50a](1c0e50a))
* **image:** backup is suggested as type in update command
([#603](#603))
([6ea4695](6ea4695))
* inconsistent formatting in "describe" commands
([#593](#593))
([b70dfe3](b70dfe3))
* **network:** create prints success to stderr instead of stdout
([#587](#587))
([0a4c361](0a4c361))
* **primary-ip:** list does now allow to output IP column
([#594](#594))
([ee8e6ed](ee8e6ed)),
closes [#591](#591)
* **primary-ip:** updating the name resets auto-delete
([#604](#604))
([292f6c4](292f6c4))
* static resource list commands only return first 50 entries
([#592](#592))
([7e511d9](7e511d9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@Porkepix Porkepix mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phm07 phm07

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@phm07 @Sathylias